Remove autoscroll on product carousel#15286
Merged
oliverabrahams merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
…s. The browser does this anyway for cards off screen. For this A/B/C test it is an optimisation we dont need.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
oliverabrahams
changed the title
oliverabrahams
added
fix
emma-imber
approved these changes
Feb 3, 2026
Contributor
emma-imber
left a comment
emma-imber
left a comment
There was a problem hiding this comment.
I think this is fine for the test, and we can revisit later on like you say!
|
Seen on PROD (merged by @oliverabrahams 7 minutes and 53 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This removes a function which causes focus events to scroll the carousel to show card clicked. Described here
Copied from the scrollable carousel. It was causing issues with the clicking on the buttons and the read more.
Why?
The focus scroll was messing around with the clicks on the cards. It is an optimisation for half showing cards, This is clashing with the read more clicks and the clicks to retailers. Making a click on a button scroll the carousel rather than go to the retailer. The browser does this anyway for cards off screen it is purely for partially visible cards.
For this A/B/C test it is an optimisation which is causing more issues than it is solving. Would be worth revisiting for when the carousel makes it to production
Before
Screen.Recording.2026-02-03.at.14.06.56.mov
After
Screen.Recording.2026-02-03.at.14.05.44.mov